Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scripts to extract workflows from WorkflowHub and UseGalaxy servers #158

Merged
merged 14 commits into from
Oct 16, 2024

Conversation

bebatut
Copy link
Member

@bebatut bebatut commented Aug 1, 2024

No description provided.

@nsoranzo
Copy link
Member

nsoranzo commented Aug 2, 2024

Fixed the linting, don't have time to look at the rest at the moment, sorry!

@bebatut
Copy link
Member Author

bebatut commented Aug 2, 2024

Fixed the linting, don't have time to look at the rest at the moment, sorry!

Thanks already for fixing the linting!!

- Add matrix strategy for test tutorial and test workflows
- Replace pull_request_target by pull_request
Copy link
Collaborator

@paulzierep paulzierep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add the output of a test run ? That would make the review simpler. Will try to check tomorrow.

Shorten tool id
"""
if "toolshed" in tool:
return tool.split("/")[-2]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are you sure it's not [-1] ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True, I just remembered we do it different for the tool stats (but there we compare wrapper ids - so all good !)

paulzierep
paulzierep previously approved these changes Oct 14, 2024
Copy link
Collaborator

@paulzierep paulzierep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and I like the OO approach, could you provide the test output, still ?

Shorten tool id
"""
if "toolshed" in tool:
return tool.split("/")[-2]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True, I just remembered we do it different for the tool stats (but there we compare wrapper ids - so all good !)

@paulzierep
Copy link
Collaborator

workflow CI fails, with

        wfhub_wfs = shared.get_request_json(
            "https://workflowhub.eu/workflows?filter[workflow_type]=galaxy",
            header,
        )

locally it worked for me, maybe we need to retry this a few times ... ?

Copy link
Collaborator

@paulzierep paulzierep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice ! Thanks @bebatut !

@paulzierep paulzierep merged commit e0d9747 into main Oct 16, 2024
10 checks passed
@paulzierep paulzierep deleted the add_workflows branch October 16, 2024 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants