Revert continuous pruning of containers #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvdbeek
approved these changes
Jul 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert #37 and prune once before each
planemo test.When testing tools for which no container exists one is built. The continuous pruning makes this fail (example). It seems that also some
./builddirectory is pruned and docker recreates it with root permissions (see). Besides this it seems more than likely that apruneis called between subsequent tests and maybe even between building the container and using it in the test. Hence the container needs to be built frequently which often needs enormous amounts of time.... besides the fact that it does not work.In addition before building the container,
conda searchcall(s) are executed using some conda container. This container (approx 500MB) is pruned in between these searches. For tools like multigsea that have some requirements this leads to GBs of useless downloads (but maybe github uses some caching).