Add a slurm_init command. #1543
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I can test this tomorrow considering I just spent time on getting that to work 😅 |
mvdbeek
force-pushed
the
cmd_slurm_init
branch
2 times, most recently
from
4eefcbc to
f5e0d85
Compare
It should allow simplify the documentation for using SLURM, allow for auto-testing the documentation, and having a fixed location to expect the slurm library by default could allow us to auto pick it up if it is available.
1.1.4 doesn't compile against slurm on anvil
|
After a few tweaks it's working!
|
|
This is super cool. You shouldn't need to run autogen.sh, btw, and that could fail on some hosts that don't have the right dev packages installed. autogen generates the autoconf/automake stuff, but that is already done in the tarballs as part of the release. |
|
I'll fix it |
|
I just realized - this would be great to have in galaxy-job-config-init as well. Since it's now a dep of planemo maybe just move it there? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It should allow simplify the documentation for using SLURM, allow for auto-testing the documentation, and having a fixed location to expect the slurm library by default could allow us to auto pick it up if it is available.
@Smeds Any chance you'd be willing to test this with your setup and then use it to simplify the docs you're adding #1512?