Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "use_header_names" option to histogram #631

Merged
merged 3 commits into from
Feb 7, 2025

Conversation

hechth
Copy link
Contributor

@hechth hechth commented Jan 23, 2025

The histogram plotting tool doesn't use the header to display the column selection, which is quite inconvenient.

In case there is no header, I think this should still work? Or should we add a boolean to check whether the file has a header?

@hechth
Copy link
Contributor Author

hechth commented Feb 3, 2025

@jdavcs or @nsoranzo could someone review and merge this please? Thanks a lot!

@jdavcs jdavcs self-assigned this Feb 5, 2025
Copy link
Member

@jdavcs jdavcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine. Works for me. @nsoranzo can you double-check, please? (I don't review tool edits often, so I may be missing something)

@jdavcs jdavcs merged commit e67a9cc into galaxyproject:main Feb 7, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants