Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a test for the ranking function using locations of the destinations #108

Draft
wants to merge 25 commits into
base: main
Choose a base branch
from
Draft

Add a test for the ranking function using locations of the destinations #108

wants to merge 25 commits into from

Conversation

pauldg
Copy link
Contributor

@pauldg pauldg commented Jul 10, 2023

This test tries to match object stores to their closest destinations using latitude and longitude.

@pauldg pauldg mentioned this pull request Jul 10, 2023
Open
nuwang
nuwang reviewed Nov 22, 2023
View reviewed changes
Copy link
Member

@nuwang nuwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the location related tests are fairly standalone, could you move it into its own folder under tests? That'll make them easier to find since they are grouped together.

@pauldg pauldg mentioned this pull request Feb 5, 2024
Merged
@pauldg pauldg marked this pull request as draft March 7, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nuwang nuwang nuwang left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pauldg @nuwang @cat-bro