Merge pull request #4401 from galaxyproject/risk-squeaker

fix sending empty news
galaxyproject · Oct 9, 2023 · afc517d · afc517d
2 parents 35045d8 + 0dbbfb3
commit afc517d
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/bin/news.rb b/bin/news.rb
@@ -149,7 +149,7 @@ def build_news(data, filter: nil)
 
   if filter.nil?
   output += format_news(data[:added][:news])
-  newsworthy = newsworthy | format_news(data[:added][:news]).length
+  newsworthy = newsworthy | format_news(data[:added][:news]).length.positive?
   end
 
   o = format_tutorials(
@@ -158,14 +158,14 @@ def build_news(data, filter: nil)
   )
 
   output += o
-  newsworthy = newsworthy | o.length
+  newsworthy = newsworthy | o.length.positive?
 
   o = format_tutorials(
     data[:added][:slides].select{|n| filter.nil? || n[:path] =~ /topics\/#{filter}/ },
     data[:modified][:slides].select{|n| filter.nil? || n[:path] =~ /topics\/#{filter}/ }
   )
   output += o
-  newsworthy = newsworthy | o.length
+  newsworthy = newsworthy | o.length.positive?
 
   if filter.nil? && data[:contributors].length.positive?
     newsworthy = true