Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating short tutorial #4386

Merged
merged 45 commits into from
Nov 27, 2023

Conversation

nekrut
Copy link
Collaborator

@nekrut nekrut commented Oct 6, 2023

Major update to the tutorial including new data upload section, syncing with WFids as specified in NatBiotech paper

@nekrut nekrut requested a review from a team as a code owner October 6, 2023 17:44
@shiltemann shiltemann marked this pull request as ready for review November 9, 2023 17:13
@nekrut
Copy link
Collaborator Author

nekrut commented Nov 9, 2023

@shiltemann -> still not quite ready as it is missing some factual pieces. I'll remove WIP once I'm ready

@nekrut nekrut requested a review from hexylena November 21, 2023 15:52
@nekrut nekrut changed the title Updating short tutorial (WIP) Updating short tutorial Nov 21, 2023
@nekrut
Copy link
Collaborator Author

nekrut commented Nov 21, 2023

@hexylena -> I think those are embed warning that cause linting to fail. Can we just ignore these. Please merge this

@nekrut
Copy link
Collaborator Author

nekrut commented Nov 27, 2023

@shiltemann -> can we merge this?

@shiltemann
Copy link
Member

@nekrut will do ..I accidentally reviewed and pushed to your other PR, will fix and add here, then merge

@shiltemann shiltemann dismissed hexylena’s stale review November 27, 2023 16:58

changes have been made

@shiltemann
Copy link
Member

@nekrut, I will merge this once the build test passes. It will probably create a bunch of merge conflicts on the long tutorial PR, will fix those tomorrow.

@shiltemann shiltemann merged commit def5a19 into galaxyproject:main Nov 27, 2023
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants