NEW LESSON ENA sequence submission #4447
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkamieniecka
requested review from
a team,
bebatut,
shiltemann and
hexylena
as code owners
hexylena
reviewed
Oct 23, 2023
| def self.zenodo_api(contents) | ||
| find_matching_texts(contents, /(zenodo\.org\/api\/files\/)/) | ||
| .map do |idx, _text, selected| | ||
| ReviewDogEmitter.error( | ||
| path: @path, | ||
| idx: idx, | ||
| match_start: selected.begin(1), | ||
| match_end: selected.end(1) + 1, | ||
| replacement: nil, | ||
| message: 'The Zenodo.org/api URLs are not stable, you must use a URL of the format zenodo.org/record/..., apologies we cannot fix automatically.', | ||
| code: 'GTN:032' | ||
| ) | ||
| end | ||
| end | ||
|
|
||
| def self.fix_md(contents) |
There was a problem hiding this comment.
this PR seems to have the same issue sadly, but if you can fix it i'll get it reviewed asap :)
|
Please see #4454 (comment) for suggested resolution f the PR issues. |
hexylena
added a commit
that referenced
this pull request
Nov 1, 2023
NEW LESSON ENA sequence submission #4447
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lesson covering ENA sequence submission