-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alphapose #113
base: master
Are you sure you want to change the base?
Alphapose #113
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work. I reviewed the PR and left some comments.
; Supported models: mobilenet_ssd_v2 and openpifpaf | ||
Name = openpifpaf | ||
; Supported models: mobilenet_ssd_v2 , openpifpaf and alphapose_mobilenet_ssd | ||
Name = alphapose_mobilenet_ssd | ||
;ImageSize should be 3 numbers seperated by commas, no spaces: 300,300,3 (for better accuracy use higher resolution when | ||
; using openpifpaf (openpifpaf detects both faces and pedestrians) | ||
ImageSize = 1281,721,3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The ImageSize is used for Alphapose?
I think leave a comment for ImageSize and its usage can be helpful.
for i, box in enumerate(boxes): | ||
inps[i], cropped_box = self._transform_single_detection(image, box) | ||
cropped_boxes[i] = torch.FloatTensor(cropped_box) | ||
return inps, cropped_boxes, boxes, scores, ids |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you docstring the inputs and outputs shape and type.
cropped_boxes[i] = torch.FloatTensor(cropped_box) | ||
return inps, cropped_boxes, boxes, scores, ids | ||
|
||
def _transform_single_detection(self, image, bbox): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Docstring of the input/output shape and type here.
|
||
return img, bbox | ||
|
||
def _post_process(self, hm, cropped_boxes, boxes, scores, ids): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Docstring of the input and output shapes and types
@@ -0,0 +1,21 @@ | |||
from models.fastpose import FastPose |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add the reference if you copy this module from another repo otherwise it's not neccessary.
@@ -0,0 +1,204 @@ | |||
import os |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it neccessary to use this module? If not, you can remove it.
@@ -0,0 +1,33 @@ | |||
import numpy as np |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add reference if this module is copied from another repo.
@@ -0,0 +1,200 @@ | |||
import numpy as np |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add reference.
@@ -0,0 +1,119 @@ | |||
import numpy as np |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reference
inference function sets input tensor to input image and gets the output. | ||
The model provides corresponding detection output which is used for creating result | ||
Args: | ||
resized_rgb_image: uint8 numpy array with shape (img_height, img_width, channels) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
change 'resized_rgb_image' to 'image' at docstring
add AlphaPose Pose Estimator.