Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(posts): add a wrapper to have custom selectorCallback #3427

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

Arukuen
Copy link
Contributor

@Arukuen Arukuen commented Feb 11, 2025

fixes #3421
fixes #3422

  • The selectorCallback in posts/style.js affects all block styles turning all the selectors to ‘.stk-img-wrapper’, without the appropriate additional selector definition.
    • First Approach: Change the base selector to the return value of selectorCallback. But this requires the getAttributeFunc in the image/style.js which might not be a clean approach.
    • Used Approach: Wrap selectorCallback and pass the selector. This allow custom selectorCallback per block style.

Copy link

🤖 Pull request artifacts

file commit
pr3427-stackable-3427-merge.zip b362bc5

github-actions bot added a commit that referenced this pull request Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant