-
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ImageTag to support Unity 6 versions #106
base: main
Are you sure you want to change the base?
Conversation
Unity has went from unity 20xx.x.xxxx to 6000.x.xxxx and it made activations broken. This should fix it.
WalkthroughThe change updates the regular expression used in the Changes
Poem
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
src/model/image-tag.ts (1)
30-30
: Regular expression updated to support Unity 6 versioning - LGTM!The change correctly expands the pattern to accept both the traditional Unity version format (20xx.x.xxxx) and the new Unity 6 format (6000.x.xxxx). The pattern is properly structured with parentheses grouping the alternatives together.
Note: There's a minor formatting issue indicated by the linter. You should add a space after
return
for consistency.- return /^(20\d{2}\.\d\.\w{3,4}|6000\.\d\.\w{3,4})$/; + return /^(20\d{2}\.\d\.\w{3,4}|6000\.\d\.\w{3,4})$/;🧰 Tools
🪛 ESLint
[error] 30-30: Insert
·
(prettier/prettier)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
src/model/image-tag.ts
(1 hunks)
🧰 Additional context used
🪛 ESLint
src/model/image-tag.ts
[error] 30-30: Insert ·
(prettier/prettier)
Unity went from 20xx.x.xxxx to 6000.x.xxxx, which broke activations. This should fix it.
Changes
Checklist
Summary by CodeRabbit