Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(protocols/minetest): rename ip to address #678

Merged
merged 2 commits into from
Feb 26, 2025
Merged

fix(protocols/minetest): rename ip to address #678

merged 2 commits into from
Feb 26, 2025

Conversation

hjri
Copy link
Contributor

@hjri hjri commented Feb 26, 2025

Minetest changed property name in list

@hjri
Update minetest protocol
908c972 
Minetest changed property name in list
@CosminPerRam CosminPerRam changed the title Update minetest protocol fix(protocols/minetest): rename ip to address Feb 26, 2025
CosminPerRam
CosminPerRam reviewed Feb 26, 2025
View reviewed changes
Copy link
Member

@CosminPerRam CosminPerRam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix, please also add a line in the CHANGELOG (if you want to, I could do it), something like this:
Fix: Minetest - server filtering replace missing field ip with address (By @hjri #678)

@hjri
Copy link
Contributor Author

hjri commented Feb 26, 2025

done

@CosminPerRam CosminPerRam merged commit f0c3b76 into gamedig:master Feb 26, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CosminPerRam CosminPerRam CosminPerRam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hjri @CosminPerRam