Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update control systems #409

Merged
merged 9 commits into from
Nov 2, 2023

Conversation

seakrueger
Copy link
Contributor

Started as wanting to add a warning about the upcoming illegalization of Androids phones as RC controllers, (See note in RE06). I ended up updating most of the page since it seemed some of the information on the page hasn't been updated past ~Skystone.

@abidingabi abidingabi added Software Has to do with software Type: Enhancement Add information that isn't already present in an article labels Oct 26, 2023
@seakrueger seakrueger force-pushed the update-control-systems branch from 54effe8 to f668407 Compare October 26, 2023 20:16
@seakrueger seakrueger marked this pull request as draft October 26, 2023 23:05
@seakrueger seakrueger marked this pull request as ready for review October 27, 2023 15:49
@@ -3,47 +3,52 @@
Control Systems
===============

The FTC control system is based on using Android phones as a ":term:`Robot Controller`" and a ":term:`Driver Station`." The ":term:`Robot Controller`" phone is mounted on the robot and connected by a USB cable to a special "Hub", which in turn is connected to motors, servos, and sensors.
The FTC control system is based around a ":term:`Robot Controller`" and a ":term:`Driver Station`". The :term:`Robot Controller` is mounted on the robot and are connected to special "Hub(s)", which in turn connect to motors, servos, and sensors. The :term:`Robot Controller` is linked to the :term:`Driver Station` through WiFi Direct.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The FTC control system is based around a ":term:`Robot Controller`" and a ":term:`Driver Station`". The :term:`Robot Controller` is mounted on the robot and are connected to special "Hub(s)", which in turn connect to motors, servos, and sensors. The :term:`Robot Controller` is linked to the :term:`Driver Station` through WiFi Direct.
The FTC control system is based around a ":term:`Robot Controller`" and a ":term:`Driver Station`". The :term:`Robot Controller` is mounted on the robot and is connected to special "Hub(s)", which in turn connect to motors, servos, and sensors. The :term:`Robot Controller` is linked to the :term:`Driver Station` through WiFi Direct.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This paragraph doesn't really account for the fact that the Robot Controller can itself be a REV Hub. Additionally, the Control Hub does not use Wi-Fi Direct in any way. Instead, it broadcasts a standard Wi-Fi access point.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thoughts:
The FTC control system is based around a ":term:Robot Controller" and a ":term:Driver Station". The :term:Robot Controller is mounted on the robot and handles motors, servos, sensors, and input from the drivers' controllers. The :term:Driver Station remain with the drive team and connects to the :term:Robot Controller over WiFi.

Adds some ambiguity to the Robot Controller definition, just giving a very basic overview of its purpose. This leaves the second paragraph for actually describing the hubs. Also fixes up the WiFi Direct mistake.

source/docs/power-and-electronics/control-system.rst Outdated Show resolved Hide resolved
@abidingabi abidingabi merged commit 171d649 into gamemanual0:main Nov 2, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Software Has to do with software Type: Enhancement Add information that isn't already present in an article
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants