Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add asking effective questions page #432

Merged
merged 9 commits into from
Jul 29, 2024
Merged

Conversation

Ridleyyy
Copy link
Contributor

Added a page detailing how to ask questions effectively.

Ridleyyy added 2 commits July 16, 2024 11:42
Added a page detailing how to ask questions effectively.
Broke down paragraphs into separate lines for each sentence to simplify blame and merge processes.
Add step about sharing progress of existing attemps to solve problem.
Fixed numbering of list.
Copy link

@j5155 j5155 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall great so far! I have a few grammar suggestions and some things to potentially add.

@j5155
Copy link

j5155 commented Jul 21, 2024

Forgot to mention this in the review, but also mentioning something about explaining how you solved the problem when you solve it on your own to prevent https://xkcd.com/979/ would be great.

@Ridleyyy
Copy link
Contributor Author

Forgot to mention this in the review, but also mentioning something about explaining how you solved the problem when you solve it on your own to prevent https://xkcd.com/979/ would be great.

Included this at the end, thanks for all the suggestions.

Copy link
Member

@abidingabi abidingabi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, this looks great, however I requested some changes, mostly around formatting. Once those are fixed I would be happy to merge this, thank you for your contribution :).

Copy link
Member

@abidingabi abidingabi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for your contribution :)

@abidingabi abidingabi merged commit 904dc59 into gamemanual0:main Jul 29, 2024
8 checks passed
@Ridleyyy Ridleyyy deleted the remote branch July 29, 2024 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants