Add support for miniBill/codec #13
Conversation
|
Looks good but I would be happier if there was a test (even something simple like FuzzerCodeGenTest.elm). See the docs for fakeDependency on how to generate that value. And also please update the README as well :) |
|
Oops, yes got excited and forgot the boring details. Will fix in a moment. |
|
I copied the elm-serialize tests and changed them to fit elm-codec. Only two tests are still failing. For some reason Maybe isn't being detected as a core type and code gen is generating a |
| , CodeGenerator.float (val "float") | ||
| , CodeGenerator.string (val "string") | ||
| , CodeGenerator.list (fn1 "list") | ||
| , CodeGenerator.maybe (fn1 "nullable") |
There was a problem hiding this comment.
| , CodeGenerator.maybe (fn1 "nullable") | |
| , CodeGenerator.use "Codec.nullable" |
This might fix the Maybe related issues. This is an annoying workaround, but I haven't quite figured out how to fix this issue properly.
There was a problem hiding this comment.
I tried that but it doesn't seem to work either. The thing is, I first used Codec.maybe which wasn't correct but ought to have worked for code gen but didn't for some reason. I'm confused what difference there could be that causes elm-serialize to correctly handle Maybe but not elm-codec.
There was a problem hiding this comment.
Ok I’ll try to find some time on Monday to look into it a bit more.
There was a problem hiding this comment.
OK, I fixed this, it turned out there was a stupid oversight in the code that was managing this stuff which just happened to work for the other use case because of different source order :(
@miniBill you can now generate your codecs with elm-review-todo-it-for-me!