Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Connect URL #8

Merged
merged 3 commits into from
Mar 21, 2024
Merged

Fix Connect URL #8

merged 3 commits into from
Mar 21, 2024

Conversation

TosinJs
Copy link
Collaborator

@TosinJs TosinJs commented Mar 21, 2024

Description

  • Fix connect url issue
  • Fix issue with .default in JS environments

https://www.loom.com/share/f6122e77564046819f6220a1a7eae6f2

Motivation and Context

How Has This Been Tested?

Screen recording (compulsory):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Improvement (general improvements to how code looks/works)

Checklist

  • I have created a branch for this patch/feature.
  • My pull request addresses exactly one patch/feature.
  • Each individual commit in the pull request is meaningful.
  • I have tested manually on my deployed review app.
  • My code follows the code style of this project.
  • I have requested and received approval from a peer
  • I have requested and received (initial) approval from the code owner
  • I have completed QA testing
  • I have received final approval from the code owner

@TosinJs TosinJs merged commit d98ab66 into staging Mar 21, 2024
1 check passed
TosinJs added a commit that referenced this pull request Mar 21, 2024
@TosinJs @timigod
Staging -> Prod [ Fix Connect URL ] (#9)
4ae1cc7 
* SDK Init (#1)

* First Itr With Check in Initialization

* Sync Initialization

* Validate no required service

* Use graphql-codegen

* Use ENV For Codegen

* Custom Error Codes

* Error Modules

* Fix copy errors

* Github Workflow and Readme (#2)

* Github Workflow

* Minor Mods

* Update Readme

* Update Readme.md

* Update README.md

* Update README.md

* Update README.md

---------

Co-authored-by: Timi Ajiboye <[email protected]>

* Modify Publish Workflow (#3)

* Modify Publish Workflow

* Update Readme.md

* Update Workflow

* Fix Test (#5)

* Update Graphql Queries to use the Public API (#6)

* Update Graphql Schema

* Update Version

* Fix Connect URL (#8)

* Fix Connect URL

* Use Multiple Export Paths

* Fix Test

---------

Co-authored-by: Timi Ajiboye <[email protected]>
TosinJs added a commit that referenced this pull request Mar 21, 2024
@TosinJs @timigod
Staging -> Prod [ Use Rollup ] (#11)
b5de672 
* SDK Init (#1)

* First Itr With Check in Initialization

* Sync Initialization

* Validate no required service

* Use graphql-codegen

* Use ENV For Codegen

* Custom Error Codes

* Error Modules

* Fix copy errors

* Github Workflow and Readme (#2)

* Github Workflow

* Minor Mods

* Update Readme

* Update Readme.md

* Update README.md

* Update README.md

* Update README.md

---------

Co-authored-by: Timi Ajiboye <[email protected]>

* Modify Publish Workflow (#3)

* Modify Publish Workflow

* Update Readme.md

* Update Workflow

* Fix Test (#5)

* Update Graphql Queries to use the Public API (#6)

* Update Graphql Schema

* Update Version

* Fix Connect URL (#8)

* Fix Connect URL

* Use Multiple Export Paths

* Fix Test

* Use Rollup to Compile Files

* Fix Tests

* Improved Error Handling

* Merge branch 'main' into staging

---------

Co-authored-by: Timi Ajiboye <[email protected]>
TosinJs added a commit that referenced this pull request Mar 23, 2024
@TosinJs @timigod
Staging -> Prod [ Update Required Node Version ] (#14)
6da6ecd 
* SDK Init (#1)

* First Itr With Check in Initialization

* Sync Initialization

* Validate no required service

* Use graphql-codegen

* Use ENV For Codegen

* Custom Error Codes

* Error Modules

* Fix copy errors

* Github Workflow and Readme (#2)

* Github Workflow

* Minor Mods

* Update Readme

* Update Readme.md

* Update README.md

* Update README.md

* Update README.md

---------

Co-authored-by: Timi Ajiboye <[email protected]>

* Modify Publish Workflow (#3)

* Modify Publish Workflow

* Update Readme.md

* Update Workflow

* Fix Test (#5)

* Update Graphql Queries to use the Public API (#6)

* Update Graphql Schema

* Update Version

* Fix Connect URL (#8)

* Fix Connect URL

* Use Multiple Export Paths

* Fix Test

* Use Rollup to Compile Files

* Fix Tests

* Improved Error Handling

* Merge branch 'main' into staging

* Set required node version

---------

Co-authored-by: Timi Ajiboye <[email protected]>
TosinJs added a commit that referenced this pull request Mar 25, 2024
@TosinJs @timigod
Staging -> Prod [ Update URI Encoding Method ] (#17)
0338048 
* SDK Init (#1)

* First Itr With Check in Initialization

* Sync Initialization

* Validate no required service

* Use graphql-codegen

* Use ENV For Codegen

* Custom Error Codes

* Error Modules

* Fix copy errors

* Github Workflow and Readme (#2)

* Github Workflow

* Minor Mods

* Update Readme

* Update Readme.md

* Update README.md

* Update README.md

* Update README.md

---------

Co-authored-by: Timi Ajiboye <[email protected]>

* Modify Publish Workflow (#3)

* Modify Publish Workflow

* Update Readme.md

* Update Workflow

* Fix Test (#5)

* Update Graphql Queries to use the Public API (#6)

* Update Graphql Schema

* Update Version

* Fix Connect URL (#8)

* Fix Connect URL

* Use Multiple Export Paths

* Fix Test

* Use Rollup to Compile Files

* Fix Tests

* Improved Error Handling

* Merge branch 'main' into staging

* Set required node version

* Update URI Encoding Method

* Update Tests

* lowercase services

* fix tests

---------

Co-authored-by: Timi Ajiboye <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timigod timigod timigod approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TosinJs @timigod