Moved inline DOM functions to within constructor #843
+34
−7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Server-side Rendering enabled frameworks try to run the code beforehand. Some of them like SvelteKit don't like it when inline DOM methods are present. It's a relatively light/easy fix - we just moved the few instances of these DOM methods from within the Tiny-Slider codebase into a function that is called within the TNS constructor.
No real changes to the code-base and yet the plugin can be used within SSR frameworks like SvelteKit. Thanks team!