Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs.md #181

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Update docs.md #181

wants to merge 2 commits into from

Conversation

markbrewster
Copy link

No description provided.

@newkind
Copy link
Contributor

newkind commented Feb 6, 2019

I'd add 2 modifications to thie PR.

  1. Change the BLOG_NUMBER to the SITENAME-ID as BLOG_NUMBER can be confusing and misleading if someone uses different name than BLOG

  2. Add information that each custom.scss will be available only for the site that this particular custom configuration belongs to.

Copy link
Author

@markbrewster markbrewster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the suggestions @newkind I have amended the copy.

@newkind
Copy link
Contributor

newkind commented Feb 6, 2019

@markbrewster Thanks for the updates.

@mahagr One more question for you here. Can you please check in the code if having a multisite installation means that Gantry 5 will always look for custom.scss only under custom/SITENAME-ID/scss/ or both locations custom/scss/ and custom/SITENAME-ID/scss/ ?

It really should do both in this case, so you could have global custom.scss and per site custom.scss.

@mahagr
Copy link
Member

mahagr commented Feb 13, 2019

I believe that custom folder is used only from the current template, mostly because of configuration is stored in there and it would be confusing that changing parent configuration or layouts also changes them from the child theme.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants