let AutoDoc
set an exit code in the case of failure
#280
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea is the same as in gap-system/gap/pull/5835, but here we deal with package documentation:
When building a manual, collect the info messages printed by
MakeGAPDocDoc
, use a heuristic to decide whether the result is acceptable, and letmakedoc.g
report failure if not; this can be used in automated tests.For that, the function
AutoDoc
now ~~returns a record; up to now, it had no return value.~~sets a nonzero exit code if applicable.This change will automatically become available in all packages that use
makedoc.g
containingAutoDoc
calls. This should not cause problems because the exit code of processingmakedoc.g
did not have a meaning before the change.