update PackageInfo.g for GAP 4.14
#41
Conversation
ThomasBreuer
commented
Nov 13, 2024
ThomasBreuer
commented
- some components are now optional
- there are new components
- some statements were outdated
- some components are now optional - there are new components - some statements were outdated
|
Once the update is merged, a new release of the package is needed, and the new version should become part of GAP 4.14, see gap-system/gap/issues/5818. |
PackageInfo.g
Outdated
| ## # these are compulsory, the strings can be encoded in UTF-8 or latin1, | ||
| ## # 'LastName' is mandatory. | ||
| ## # 'FirstNames' is optional from GAP 4.14 on, was mandatory before. | ||
| ## # The strings can be encoded in UTF-8 or latin1, |
There was a problem hiding this comment.
That's not really true anymore either: if the text is not UTF-8, it will be displayed incorrectly on e.g. the website and other places. Because there is no magic way for us to detect different encodings...
In practice I would say everything should use UTF-8 encoding.
There was a problem hiding this comment.
Interesting.
In fact nothing is said about the encoding in the section "The PackageInfo.g File" of the GAP Reference Manual.
The (undocumented!) function DefaultPackageBannerString explicitly converts some HTML encoded lowercase umlauts to the right strings for the current GAP session, because some PackageInfo.g seem to use this (or did this in the past).
I will update the current pull request.
And in the long run, the abovementioned manual section should be improved accordingly.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #41 +/- ##
=======================================
Coverage 62.09% 62.09%
=======================================
Files 3 3
Lines 153 153
=======================================
Hits 95 95
Misses 58 58 |
