Skip to content

Commit

Permalink
Avoid trivial function wrappers
Browse files Browse the repository at this point in the history
That is, use 'f' instead of 'x -> f(x)' and so on.
  • Loading branch information
james-d-mitchell authored and ChrisJefferson committed Jan 11, 2024
1 parent e00b01f commit 81abd71
Show file tree
Hide file tree
Showing 6 changed files with 7 additions and 9 deletions.
3 changes: 1 addition & 2 deletions lib/alglie.gi
Original file line number Diff line number Diff line change
Expand Up @@ -4817,8 +4817,7 @@ local ReductionModuloTable, #
# i.e., the previous loop has been executed without breaking
# caused by finding a relation among the generators.

vg:=Difference( List( Combinations(e[1],2), x -> Reversed(x) ),
R[2] );
vg:=Difference( List( Combinations(e[1],2), Reversed ), R[2] );
Append( R[2], vg );
for i in [1..Length(vg)] do
d:=d+1;
Expand Down
2 changes: 1 addition & 1 deletion lib/algrep.gi
Original file line number Diff line number Diff line change
Expand Up @@ -3295,7 +3295,7 @@ InstallMethod( ZeroOp,
function( u )

return ObjByExtRep( FamilyObj( u ), List(
FamilyObj( u )!.constituentModules, V -> Zero(V) ) );
FamilyObj( u )!.constituentModules, Zero ) );
end );


Expand Down
2 changes: 1 addition & 1 deletion lib/gprd.gi
Original file line number Diff line number Diff line change
Expand Up @@ -357,7 +357,7 @@ InstallGlobalFunction (PcgsDirectProduct,
rels := [];
pcgs := [];
indices := [];
one := List( info.groups, x -> One(x) );
one := List( info.groups, One );
offset := 0;
for i in [1..Length(info.groups)] do
pcgs[i] := pcgsop ( info.groups[i] );
Expand Down
2 changes: 1 addition & 1 deletion lib/grppcatr.gi
Original file line number Diff line number Diff line change
Expand Up @@ -932,7 +932,7 @@ function( G )
exp := 1;
while Size( U ) < Size( G ) do
sub := Filtered( cl, x -> Order( Representative( x ) ) = p ^ exp );
sub := Concatenation( List( sub, x -> AsList(x) ) );
sub := Concatenation( List( sub, AsList ) );
sub := InducedPcgsByPcSequenceAndGenerators( pcgs, Pcgs(U), sub );
M := SubgroupByPcgs( G, sub );
if Size( M ) > Size( U ) then
Expand Down
5 changes: 2 additions & 3 deletions lib/helpbase.gi
Original file line number Diff line number Diff line change
Expand Up @@ -1372,13 +1372,13 @@ InstallGlobalFunction(HELP, function( str )

# if the topic is 'chapters' display the table of chapters
elif str = "chapters" or str = "contents" or book <> "" and str = "" then
if ForAll(books, b-> HELP_SHOW_CHAPTERS(b)) then
if ForAll(books, HELP_SHOW_CHAPTERS) then
add( books, "chapters", "chapters" );
fi;

# if the topic is 'sections' display the table of sections
elif str = "sections" then
if ForAll(books, b-> HELP_SHOW_SECTIONS(b)) then
if ForAll(books, HELP_SHOW_SECTIONS) then
add(books, "sections", "sections");
fi;

Expand Down Expand Up @@ -1409,4 +1409,3 @@ InstallGlobalFunction(HELP, function( str )
# Print( "Help: Sorry, could not find a match for '", origstr, "'.\n");
fi;
end);

2 changes: 1 addition & 1 deletion lib/lierep.gi
Original file line number Diff line number Diff line change
Expand Up @@ -4079,7 +4079,7 @@ InstallGlobalFunction( ExtendRepresentation,
n:= Length( mats[1] );

for i in [1..Length(mats)] do
Q:= List( mats[i], x -> ShallowCopy(x) );
Q:= List( mats[i], ShallowCopy );
for j in [1..n] do
Add( Q[j], Zero( F ) );
od;
Expand Down

0 comments on commit 81abd71

Please sign in to comment.