-
Notifications
You must be signed in to change notification settings - Fork 164
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
* Rename tst/testutil.g -> tst/delegation.g Also remove an outdated (now incorrect) comment referencing that file; and remove an old bugfix test accessing it: it is not clear what that bugfix was supposed to test: it used to invoke just `ReadGapRoot` but was rewritten to call `IsReadableFile`+`Filename`+`DirectoriesLibrary`; but it is not clear what either is supposed to test, exactly. * tst: move two files into tst/testinstall/ Those files are only used by `testinstall` so it makes sense to move them in there. But primarily, it gets us closer to having all files with a name of the form `tst/test*.g` serving the same purpose, namely to run a testsuite with corresponding name. * tst: unify some permutation constructor tests Properly test bounds checks in the kernel for creating permutations: one of the errors can only ever be reached in 64 bit mode; the other however can always be reached, and thus should always be tested. Note that the tst/test32bit and tst/test64bit directories were supposed to be removed in 2018 (!) and files in there were in fact not loaded since then (!!). My guess is that a file in each remained because of PRs being merged "out of order" so that the PR which was supposed to remove those dirs was merged only after some other PR added new files. But we actually tested the constructors as part of the `RestrictedPerm` tests, but it really wasn't appropriate there (the tests didn't even reach `RestrictedPerm` as the kernel errors occur before the call).
- Loading branch information
Showing
11 changed files
with
9 additions
and
28 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
File renamed without changes.