Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix IsCheapConwayPolynomial( p, 1 ) for p < 1000 #5531

Merged
merged 2 commits into from
Nov 17, 2023
Merged

Fix IsCheapConwayPolynomial( p, 1 ) for p < 1000 #5531

merged 2 commits into from
Nov 17, 2023

Conversation

frankluebeck
Copy link
Member

Should always return 'true' in this range. Noticed by Thomas Breuer (issue #5444 in github).

Text for release notes

We track noteworthy changes as entries in the CHANGES.md file in the root directory of this repository. To help us decide whether and how to describe your PR, please do one of the following:

none

@frankluebeck
Fix IsCheapConwayPolynomial( p, 1 ) for p < 1000
9a379bf 
Should always return 'true' in this range. Noticed by Thomas Breuer
(issue gap-system#5444 in github).
@ThomasBreuer ThomasBreuer added the release notes: not needed PRs introducing changes that are wholly irrelevant to the release notes label Nov 14, 2023
@ThomasBreuer ThomasBreuer self-requested a review November 14, 2023 12:35
ThomasBreuer
ThomasBreuer approved these changes Nov 14, 2023
View reviewed changes
Copy link
Contributor

@ThomasBreuer ThomasBreuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.
(Perhaps the test that IsCheapConwayPolynomial( 997, 1 ); now returns true could be added to tst/testinstall/ffeconway.tst.)

@fingolfin fingolfin linked an issue Nov 17, 2023 that may be closed by this pull request
IsCheapConwayPolynomial( p, 1 )? #5444
Closed
@fingolfin fingolfin enabled auto-merge (squash) November 17, 2023 07:57
@fingolfin fingolfin added kind: bug Issues describing general bugs, and PRs fixing them kind: bug: wrong result Issues describing bugs that result in mathematically or otherwise wrong results, and PRs fixing them and removed kind: performance improvement labels Nov 17, 2023
@fingolfin fingolfin merged commit 962db5c into gap-system:master Nov 17, 2023
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThomasBreuer ThomasBreuer ThomasBreuer approved these changes

@fingolfin fingolfin fingolfin approved these changes

Assignees
No one assigned
Labels
kind: bug: wrong result Issues describing bugs that result in mathematically or otherwise wrong results, and PRs fixing them kind: bug Issues describing general bugs, and PRs fixing them release notes: not needed PRs introducing changes that are wholly irrelevant to the release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

IsCheapConwayPolynomial( p, 1 )?
3 participants
@frankluebeck @fingolfin @ThomasBreuer