Fix CyclotomicPol(501) and others #5728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... by ensuring the content of CYCPOLCache is immutable, and CYCPOLCache.CPdiffodd returns a copy (so we can't accidentally modify the cache content)
fingolfin
added
regression
ChrisJefferson
approved these changes
May 28, 2024
|
Oh, I only just noticed you asked @frankluebeck for a review. If @frankluebeck has any issues, I will un-merge the PR, so let us know if you have any concerns. |
There was a problem hiding this comment.
Thanks for spotting this. This was a bug in #5728; the function should not return the object that is stored in the cache. (I would have used ShallowCopy instead of Immutable, but both is fine.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... by ensuring the content of CYCPOLCache is immutable, and CYCPOLCache.CPdiffodd returns a copy (so we can't accidentally modify the cache content)
PR #5707 / c1b6cf0 optimized
CyclotomicPol. Afterwards the package distribution CI tests started failing while running the tests for FactInt. Investigation lead to this.