kernel: close streams after internal exception #5896
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... then rethrow.
Otherwise we may end up with references to input/output stream objects on the stack that are invalid.
I am actually not sure why this worked so far w/o causing us crashes in various situations. I think I reasoned this through at some point in the distant past and convinced myself the code is fine as it is, but I don't see it anymore. In any case, even if for some reason it was OK after all, I feel it is better to explicitly deal with this.
Diffs best viewed with "ignore whitespace" turned on.