Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Extensions for nonsolvable group and trivial cohomology #5908

Merged
merged 1 commit into from
Jan 20, 2025
Merged

Fix Extensions for nonsolvable group and trivial cohomology #5908

merged 1 commit into from
Jan 20, 2025

Conversation

ThomasBreuer
Copy link
Contributor

@ThomasBreuer ThomasBreuer commented Jan 19, 2025 •
edited
Loading

Note that Extensions for nonsolvable groups is in fact not documented, the documentation claims that the returned groups are pc groups.

@ThomasBreuer ThomasBreuer added kind: bug Issues describing general bugs, and PRs fixing them kind: bug: unexpected error Issues describing bugs in which computation unexpectedly encounters an error, and PRs fixing them topic: library release notes: use title For PRs: the title of this PR is suitable for direct use in the release notes labels Jan 19, 2025
@ThomasBreuer ThomasBreuer requested a review from hulpke January 19, 2025 22:13
hulpke
hulpke approved these changes Jan 19, 2025
View reviewed changes
Copy link
Contributor

@hulpke hulpke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, this is needed.

@fingolfin fingolfin merged commit abb8103 into gap-system:master Jan 20, 2025
33 checks passed
@fingolfin fingolfin changed the title fix Extensions for nonsolvable group and trivial cohomology Fix Extensions for nonsolvable group and trivial cohomology Jan 20, 2025
fingolfin pushed a commit that referenced this pull request Jan 20, 2025
@ThomasBreuer @fingolfin
Fix Extensions for nonsolvable group and trivial cohomology (#5908)
2f5918d
@fingolfin
Copy link
Member

Backported to stable-4.14 in 2f5918d

@ThomasBreuer ThomasBreuer deleted the TB_Extensions_nonsolvable branch January 20, 2025 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hulpke hulpke hulpke approved these changes

Assignees
No one assigned
Labels
backport-to-4.14-DONE kind: bug: unexpected error Issues describing bugs in which computation unexpectedly encounters an error, and PRs fixing them kind: bug Issues describing general bugs, and PRs fixing them release notes: use title For PRs: the title of this PR is suitable for direct use in the release notes topic: library
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ThomasBreuer @fingolfin @hulpke