A new formula to install and compile the package IMG #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Sorry, I've missed this @laurentbartholdi. So, with this I should just close PR #8 and review this one? Glad that it worked for you, still want to test for me first.
|
I think I goofed: PR #9 was supposed to be a new formula img.rb while #8
was a small change to the directory structure; but it seems I bundled #8 in
#9.
…On Tue, Aug 3, 2021, 00:45 Alexander Konovalov ***@***.***> wrote:
***@***.**** commented on this pull request.
Sorry, I've missed this @laurentbartholdi
<https://github.com/laurentbartholdi>. So, with this I should just close
PR #8 <#8> and review this
one? Glad that it worked for you, still want to test for me first.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#9 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AARAQUCLROS6LZ6YQJTHVM3T24NYRANCNFSM432HLNTQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an example of a formula, that actually works well on my homebrew, and installs (compiles and places in appropriate place) my package IMG for use with the homebrew-gap version of gap.