Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refac: remove twilio and sendgrid libraries #116

Merged
merged 4 commits into from
Nov 8, 2024
Merged

Conversation

sbgap
Copy link
Collaborator

@sbgap sbgap commented Nov 8, 2024

Description
Remove Twilio and Sendgrid libraries, and use simple post requests to send SMS.

Changes

  • refac: remove twilio and sendgrid libraries
  • fix: change error handling of invalid NotificationKey to log that decryption of notification authentication failed
  • fix: add update of sender in notification channels

@sbgap sbgap merged commit 7798b4d into master Nov 8, 2024
14 checks passed
@sbgap sbgap deleted the notification_handlers branch November 8, 2024 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant