Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

a testing PR - please don't close, will close after testing done #175

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

a testing PR - please don't close, will close after testing done #175

wants to merge 6 commits into from

Conversation

neo-liang-sap
Copy link
Contributor

a testing PR - please don't close, will close after testing done

liangrong1984
liangrong1984 suggested changes Mar 2, 2021
View reviewed changes
Copy link

@liangrong1984 liangrong1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aaaaaaaaa

@gardener-robot gardener-robot added the needs/changes Needs (more) changes label Mar 2, 2021
@gardener-robot
Copy link
Contributor

@neo-liang-sap You have pull request review with status CHANGES_REQUESTED, please check

3 similar comments
@gardener-robot
Copy link
Contributor

@neo-liang-sap You have pull request review with status CHANGES_REQUESTED, please check

@gardener-robot
Copy link
Contributor

@neo-liang-sap You have pull request review with status CHANGES_REQUESTED, please check

@gardener-robot
Copy link
Contributor

@neo-liang-sap You have pull request review with status CHANGES_REQUESTED, please check

@neo-liang-sap neo-liang-sap added the needs/lgtm Needs approval for merging label Mar 4, 2021
@gardener-robot gardener-robot removed the needs/lgtm Needs approval for merging label Mar 4, 2021
@neo-liang-sap neo-liang-sap added the reviewed/lgtm Has approval for merging label Mar 4, 2021
@gardener-robot gardener-robot added needs/changes Needs (more) changes and removed needs/changes Needs (more) changes reviewed/lgtm Has approval for merging labels Mar 4, 2021
@neo-liang-sap neo-liang-sap added needs/lgtm Needs approval for merging reviewed/lgtm Has approval for merging labels Mar 4, 2021
@gardener-robot gardener-robot removed reviewed/lgtm Has approval for merging needs/lgtm Needs approval for merging labels Mar 4, 2021
@gardener-robot
Copy link
Contributor

@neo-liang-sap You need rebase this pull requestion with latest master branch. Please check.

@gardener-robot gardener-robot added needs/rebase Needs git rebase size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Mar 5, 2021
@vlerenc vlerenc added priority/blocker Needs to be resolved now, because it breaks the service priority/3 Priority (lower number equals higher priority) labels Mar 8, 2021
@gardener-robot gardener-robot removed the priority/3 Priority (lower number equals higher priority) label Mar 8, 2021
@neo-liang-sap neo-liang-sap added the area/auto-scaling Auto-scaling (CA/HPA/VPA/HVPA, predominantly control plane, but also otherwise) related label Mar 16, 2021
@gardener-robot
Copy link
Contributor

@neo-liang-sap You have pull request review with status CHANGES_REQUESTED, please check

@gardener-robot gardener-robot removed the needs/rebase Needs git rebase label Mar 16, 2021
@gardener-robot
Copy link
Contributor

@neo-liang-sap You have pull request review with status CHANGES_REQUESTED, please check

@gardener-robot gardener-robot added lifecycle/stale Nobody worked on this for 6 months (will further age) lifecycle/rotten Nobody worked on this for 12 months (final aging stage) and removed lifecycle/rotten Nobody worked on this for 12 months (final aging stage) labels Apr 28, 2021
@gardener-robot
Copy link
Contributor

@neo-liang-sap You have pull request review with status CHANGES_REQUESTED, please check

@gardener-robot gardener-robot added lifecycle/rotten Nobody worked on this for 12 months (final aging stage) and removed lifecycle/stale Nobody worked on this for 6 months (will further age) labels Apr 28, 2021
@gardener-robot
Copy link
Contributor

@neo-liang-sap You have pull request review with status CHANGES_REQUESTED, please check

17 similar comments
@gardener-robot
Copy link
Contributor

@neo-liang-sap You have pull request review with status CHANGES_REQUESTED, please check

@gardener-robot
Copy link
Contributor

@neo-liang-sap You have pull request review with status CHANGES_REQUESTED, please check

@gardener-robot
Copy link
Contributor

@neo-liang-sap You have pull request review with status CHANGES_REQUESTED, please check

@gardener-robot
Copy link
Contributor

@neo-liang-sap You have pull request review with status CHANGES_REQUESTED, please check

@gardener-robot
Copy link
Contributor

@neo-liang-sap You have pull request review with status CHANGES_REQUESTED, please check

@gardener-robot
Copy link
Contributor

@neo-liang-sap You have pull request review with status CHANGES_REQUESTED, please check

@gardener-robot
Copy link
Contributor

@neo-liang-sap You have pull request review with status CHANGES_REQUESTED, please check

@gardener-robot
Copy link
Contributor

@neo-liang-sap You have pull request review with status CHANGES_REQUESTED, please check

@gardener-robot
Copy link
Contributor

@neo-liang-sap You have pull request review with status CHANGES_REQUESTED, please check

@gardener-robot
Copy link
Contributor

@neo-liang-sap You have pull request review with status CHANGES_REQUESTED, please check

@gardener-robot
Copy link
Contributor

@neo-liang-sap You have pull request review with status CHANGES_REQUESTED, please check

@gardener-robot
Copy link
Contributor

@neo-liang-sap You have pull request review with status CHANGES_REQUESTED, please check

@gardener-robot
Copy link
Contributor

@neo-liang-sap You have pull request review with status CHANGES_REQUESTED, please check

@gardener-robot
Copy link
Contributor

@neo-liang-sap You have pull request review with status CHANGES_REQUESTED, please check

@gardener-robot
Copy link
Contributor

@neo-liang-sap You have pull request review with status CHANGES_REQUESTED, please check

@gardener-robot
Copy link
Contributor

@neo-liang-sap You have pull request review with status CHANGES_REQUESTED, please check

@gardener-robot
Copy link
Contributor

@neo-liang-sap You have pull request review with status CHANGES_REQUESTED, please check

@neo-liang-sap neo-liang-sap reopened this May 24, 2021
@gardener-robot gardener-robot removed the needs/rebase Needs git rebase label Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liangrong1984 liangrong1984 liangrong1984 requested changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
area/auto-scaling Auto-scaling (CA/HPA/VPA/HVPA, predominantly control plane, but also otherwise) related lifecycle/rotten Nobody worked on this for 12 months (final aging stage) needs/changes Needs (more) changes priority/blocker Needs to be resolved now, because it breaks the service size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@neo-liang-sap @gardener-robot @liangrong1984 @vlerenc