This repository has been archived by the owner on May 26, 2023. It is now read-only.
transport cmd foundation #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot
added
needs/review
gardener-robot-ci-3
added
reviewed/ok-to-test
schrodit
suggested changes
Sep 15, 2021
gardener-robot-ci-3
added
the
reviewed/ok-to-test
gardener-robot-ci-2
removed
the
reviewed/ok-to-test
gardener-robot-ci-2
added
the
reviewed/ok-to-test
gardener-robot-ci-1
removed
the
reviewed/ok-to-test
|
@enrico-kaack-comp You have pull request review open invite, please check |
gardener-robot
added
size/xl
gardener-robot-ci-1
added
reviewed/ok-to-test
schrodit
suggested changes
Sep 20, 2021
gardener-robot-ci-1
added
reviewed/ok-to-test
gardener-robot-ci-1
added
the
reviewed/ok-to-test
gardener-robot-ci-3
removed
the
reviewed/ok-to-test
gardener-robot-ci-2
added
reviewed/ok-to-test
gardener-robot-ci-2
added
the
reviewed/ok-to-test
gardener-robot-ci-3
removed
the
reviewed/ok-to-test
gardener-robot-ci-3
added
the
reviewed/ok-to-test
gardener-robot-ci-2
removed
the
reviewed/ok-to-test
enrico-kaack-comp
suggested changes
Nov 25, 2021
| func processorRoutine(inputStream io.Reader, outputStream io.WriteCloser) error { | ||
| defer outputStream.Close() | ||
|
|
||
| tmpfile, err := ioutil.TempFile("", "") |
There was a problem hiding this comment.
would interest me too
| return errors.New("archiveWriter must not be nil") | ||
| } | ||
|
|
||
| tempfile, err := ioutil.TempFile("", "") |
There was a problem hiding this comment.
explain that you use the tempFile for size calculation
There was a problem hiding this comment.
if you write a file to a tar archive, you must know the size upfront (gets written into the preceding file header)
There was a problem hiding this comment.
i mean a comment that the tempfile only exists for that reason
gardener-robot-ci-1
added
the
reviewed/ok-to-test
gardener-robot-ci-3
removed
the
reviewed/ok-to-test
gardener-robot-ci-3
added
reviewed/ok-to-test
gardener-robot-ci-2
added
reviewed/ok-to-test
jschicktanz
dismissed
schrodit’s stale review
tim's no longer active in the project
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
first PR in a series of PRs for the implementation of the CTT functionality.
Contains:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: