Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vpa release pipeline #258

Conversation

voelzmo
Copy link
Member

@voelzmo voelzmo commented Nov 22, 2023

What this PR does / why we need it:
Add a pipeline to release VPA from our fork. We're currently looking into releasing a forked VPA in the context of a complex bug where we need more debug output in the logs in case the bug occurs. This won't be a change that will be merged upstream and will only be of temporary nature.

Release note:

NONE

@gardener-robot-ci-1
Copy link

This PR proposes changes that would break the pipeline definition:

<invalid YAML>: while parsing a block mapping
  in "<unicode string>", line 92, column 11:
              vpa-recommender:
              ^
expected <block end>, but found '<block mapping start>'
  in "<unicode string>", line 110, column 12:
               vpa-admission-controller:
               ^

@gardener-robot gardener-robot added needs/review Needs review size/s Size of pull request is small (see gardener-robot robot/bots/size.py) labels Nov 22, 2023
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 22, 2023
@gardener-robot-ci-2 gardener-robot-ci-2 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 22, 2023
Copy link

@himanshu-kun himanshu-kun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

While sync with upstream we don't sync the vpa module properly IIRC , maybe @rishabh-11 could comment on this more, so please try it locally before making a release @voelzmo

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Nov 23, 2023
@himanshu-kun
Copy link

himanshu-kun commented Nov 23, 2023

/needs second-opinion
@rishabh-11 @elankath

@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 23, 2023
@gardener-robot gardener-robot added needs/second-opinion Needs second review by someone else and removed reviewed/lgtm Has approval for merging labels Nov 23, 2023
@gardener-robot
Copy link

@himanshu-kun Labels needs/@elankath, needs/@rishabh-11 do not exist.

@gardener-robot-ci-1
Copy link

The pipeline-definition has been fixed.

@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 23, 2023
@gardener-robot gardener-robot added size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) and removed size/s Size of pull request is small (see gardener-robot robot/bots/size.py) labels Nov 23, 2023
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 23, 2023
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 24, 2023
@gardener-robot
Copy link

@unmarshall, @rishabh-11 You have pull request review open invite, please check

Copy link

@himanshu-kun himanshu-kun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/needs second-opinion
@rishabh-11

@gardener-robot gardener-robot removed the needs/second-opinion Needs second review by someone else label Nov 27, 2023
Copy link

@rishabh-11 rishabh-11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added the reviewed/lgtm Has approval for merging label Nov 27, 2023
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 27, 2023
@gardener-robot-ci-3
Copy link

This PR proposes changes that would break the pipeline definition:

vertical-pod-autoscaler-enh_add-vpa-release-pipeline: Traceback (most recent call last):
  File "/usr/lib/python3.11/site-packages/concourse/replicator.py", line 141, in render
    definition_descriptor = self._render(definition_descriptor)
                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.11/site-packages/concourse/replicator.py", line 185, in _render
    'definition': factory.create_pipeline_definition(),
                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.11/site-packages/concourse/factory.py", line 83, in create_pipeline_definition
    variant = self._create_variant(
              ^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.11/site-packages/concourse/factory.py", line 138, in _create_variant
    variant._traits_dict = self._create_traits(raw_dict, variant_name)
                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.11/site-packages/concourse/factory.py", line 189, in _create_traits
    traits_dict = {
                  ^
  File "/usr/lib/python3.11/site-packages/concourse/factory.py", line 190, in <dictcomp>
    name: TraitsFactory.create(
          ^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.11/site-packages/concourse/model/traits/__init__.py", line 68, in create
    raise ModelValidationError('no such trait: ' + str(name))
model.base.ModelValidationError: no such trait: git_tags

@gardener-robot-ci-3 gardener-robot-ci-3 added ci/broken-pipeline-definition and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 28, 2023
@gardener-robot-ci-1
Copy link

The pipeline-definition has been fixed.

@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 28, 2023
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 28, 2023
Copy link

@himanshu-kun himanshu-kun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@himanshu-kun himanshu-kun merged commit 150c384 into gardener:machine-controller-manager-provider Nov 28, 2023
4 checks passed
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants