-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add vpa release pipeline #258
Add vpa release pipeline #258
Conversation
This PR proposes changes that would break the pipeline definition:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
While sync with upstream we don't sync the vpa module properly IIRC , maybe @rishabh-11 could comment on this more, so please try it locally before making a release @voelzmo
/needs second-opinion |
@himanshu-kun Labels needs/@elankath, needs/@rishabh-11 do not exist. |
The pipeline-definition has been fixed. |
@unmarshall, @rishabh-11 You have pull request review open invite, please check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/needs second-opinion
@rishabh-11
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
This PR proposes changes that would break the pipeline definition:
|
ceebd02
to
e4c2828
Compare
The pipeline-definition has been fixed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
150c384
into
gardener:machine-controller-manager-provider
What this PR does / why we need it:
Add a pipeline to release VPA from our fork. We're currently looking into releasing a forked VPA in the context of a complex bug where we need more debug output in the logs in case the bug occurs. This won't be a change that will be merged upstream and will only be of temporary nature.
Release note: