Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Race conditions in Targeted Deletion of machines by CA #341

Open
wants to merge 24 commits into
base: machine-controller-manager-provider
Choose a base branch
from
+784 −634
Open

Fix Race conditions in Targeted Deletion of machines by CA #341

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
43cffaf
[WIP] fix CA marking machines for deletion
Dec 19, 2024
0d939b0
[WIP] add mutex for machine deployment
Dec 19, 2024
98f20d3
initialise machinedeployment map in mcmManager
Dec 20, 2024
56d80ac
add Refresh method in nodegrp implementation
Dec 20, 2024
f3774f4
address review comments
Dec 24, 2024
9063248
address review comments - part 2
Dec 26, 2024
68d2046
update unit tests, misc code changes
Dec 28, 2024
b2e1c3c
review comments addressed
elankath Jan 16, 2025
c515f39
fixed broken test after refactor
elankath Jan 16, 2025
063f07a
fixed broken test
elankath Jan 16, 2025
945c74c
alternate solution using single annotation for deletion by CA
elankath Jan 28, 2025
b021a3c
fixed use of Go 1.23 functions
elankath Jan 28, 2025
3b02417
fixed test
elankath Jan 28, 2025
22ced54
added godoc for AcquireScalingMutex
elankath Jan 28, 2025
bc85986
correct godoc for machinesMarkedByCAForDeletionAnnotation
elankath Jan 29, 2025
4d33bef
changed to machineutils.TriggerDeletionByMCM
elankath Jan 29, 2025
6ea649b
removed var shadowing, added TODO to godoc for util fns
elankath Jan 29, 2025
f890502
corr var names, clear mutex acquire, releasing logs
elankath Jan 30, 2025
9d1d313
ensured IncreaseSize/DecreaseTargetSize logged delta in mutex acquir…
elankath Jan 30, 2025
b3f9167
review comments addressed: fixed unit test, adjusted log, removed red…
elankath Feb 3, 2025
7d1d0d7
all code review comments addressed
elankath Feb 3, 2025
194b65a
review feedback: unexport belongs, enforce interface
elankath Feb 3, 2025
136ea27
addreseed review comment, refactored added test for computeScaleDownData
elankath Feb 3, 2025
f31884d
review comment: preset capacity for slices
elankath Feb 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading
Loading