Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support multiline string in pullrequest_body_suffix #1054

Merged
merged 1 commit into from
Oct 2, 2024
Merged

Support multiline string in pullrequest_body_suffix #1054

merged 1 commit into from
Oct 2, 2024

Conversation

zkdev
Copy link
Member

@zkdev zkdev commented Oct 2, 2024

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

@zkdev zkdev requested review from ccwienk and 8R0WNI3 as code owners October 2, 2024 09:23
@gardener-robot gardener-robot added the needs/review Needs review label Oct 2, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Oct 2, 2024
@gardener-robot gardener-robot added the size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) label Oct 2, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Oct 2, 2024
8R0WNI3
8R0WNI3 approved these changes Oct 2, 2024
View reviewed changes
Copy link
Member

@8R0WNI3 8R0WNI3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Oct 2, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Oct 2, 2024
@zkdev zkdev merged commit c1173ae into master Oct 2, 2024
11 checks passed
@zkdev zkdev deleted the zkdev-multiline-pr-body-suffix branch October 2, 2024 09:47
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@8R0WNI3 8R0WNI3 8R0WNI3 approved these changes

@ccwienk ccwienk Awaiting requested review from ccwienk ccwienk is a code owner

Assignees
No one assigned
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@zkdev @8R0WNI3 @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot