Update Helm Charts to Support Multi Node Etcd Cluster #813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot
added
needs/review
gardener-robot-ci-3
added
reviewed/ok-to-test
|
Can you also capture somewhere in doc that right now, only nonHA etcd cluster can be deployed by helm charts for following providers. |
|
Sure @ishan16696, will mention that. |
shreyas-s-rao
requested changes
Dec 31, 2024
There was a problem hiding this comment.
@anveshreddy18 thanks a lot for taking up the long-pending task of updating the helm charts! Few comments from my side, PTAL:
- Overall, I would like the charts to support multinode etcd clusters as well, as a static configuration. Since you've already introduced many peer TLS related artefacts in the chart, it should be easy to support multinode etcd clusters too. Moreover, it would be beneficial to have etcd-backup-restore charts support multinode etcd clusters, which are more widely used than single-node clusters.
- please add newlines at the end of files - it's just good practice.
- Please add
etcd-peer-ca-secret.yamlandetcd-peer-server-tls-secret.yamlfiles, to support multinode etcd clusters
* Address review comments by @shreyas-s-rao
anveshreddy18
force-pushed
the
fix/charts
branch
from
0460237 to
8f27d9d
Compare
gardener-robot-ci-3
added
reviewed/ok-to-test
anveshreddy18
changed the title
gardener-robot-ci-3
added
the
reviewed/ok-to-test
gardener-robot-ci-2
removed
the
reviewed/ok-to-test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR updates the outdated helm charts required to setup a single member etcd cluster with etcd-wrapper and etcd-backup-restore as containers in a pod.
The changes include:
etcd-wrapperwith distrolessetcd-backup-restoreWhich issue(s) this PR fixes:
Partially Fixes #708
Special notes for your reviewer:
Currently tested with the following cloud providers & their emulators:
The remaining providers are to be tested yet.
Release note: