-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deploy shoot-cert-service on garden runtime cluster #314
Open
MartinWeindel
wants to merge
10
commits into
master
Choose a base branch
from
enh/deploy-runtime
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot
added
kind/api-change
API change with impact on API users
needs/second-opinion
Needs second review by someone else
area/control-plane
Control plane related
kind/enhancement
Enhancement, improvement, extension
needs/review
Needs review
size/xl
Size of pull request is huge (see gardener-robot robot/bots/size.py)
labels
Nov 14, 2024
gardener-robot-ci-3
added
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
needs/ok-to-test
Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
and removed
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
labels
Nov 14, 2024
MartinWeindel
force-pushed
the
enh/deploy-runtime
branch
from
November 26, 2024 14:07
579ef96
to
55dec76
Compare
gardener-robot-ci-1
added
the
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
label
Nov 26, 2024
gardener-robot-ci-3
removed
the
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
label
Nov 26, 2024
MartinWeindel
force-pushed
the
enh/deploy-runtime
branch
from
November 26, 2024 15:03
55dec76
to
b35170c
Compare
gardener-robot-ci-2
added
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
and removed
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
labels
Nov 26, 2024
/assign |
MartinWeindel
force-pushed
the
enh/deploy-runtime
branch
from
December 10, 2024 15:59
b35170c
to
06c3ca4
Compare
gardener-robot-ci-2
added
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
and removed
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
labels
Dec 10, 2024
MartinWeindel
force-pushed
the
enh/deploy-runtime
branch
from
December 11, 2024 10:18
06c3ca4
to
c11d626
Compare
gardener-robot-ci-2
added
the
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
label
Dec 11, 2024
gardener-robot-ci-1
removed
the
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
label
Dec 11, 2024
MartinWeindel
changed the title
[WIP] Deploy shoot-cert-service on garden runtime cluster
Deploy shoot-cert-service on garden runtime cluster
Dec 11, 2024
/assign |
MartinWeindel
force-pushed
the
enh/deploy-runtime
branch
from
January 2, 2025 08:08
f0c5670
to
ab4b859
Compare
gardener-robot
added
needs/second-opinion
Needs second review by someone else
and removed
reviewed/lgtm
Has approval for merging
labels
Jan 2, 2025
gardener-robot-ci-2
removed
the
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
label
Jan 2, 2025
MartinWeindel
force-pushed
the
enh/deploy-runtime
branch
from
January 2, 2025 08:19
ab4b859
to
a3b4335
Compare
gardener-robot-ci-2
added
the
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
label
Jan 2, 2025
MartinWeindel
force-pushed
the
enh/deploy-runtime
branch
from
January 2, 2025 08:20
a3b4335
to
0583a16
Compare
gardener-robot-ci-2
added
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
and removed
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
labels
Jan 2, 2025
Co-authored-by: Marc Vornetran <[email protected]>
MartinWeindel
force-pushed
the
enh/deploy-runtime
branch
from
January 3, 2025 15:02
0583a16
to
49aa413
Compare
gardener-robot-ci-2
added
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
and removed
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
labels
Jan 3, 2025
MartinWeindel
force-pushed
the
enh/deploy-runtime
branch
from
January 3, 2025 15:22
49aa413
to
21f5891
Compare
gardener-robot-ci-3
added
the
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
label
Jan 3, 2025
MartinWeindel
force-pushed
the
enh/deploy-runtime
branch
from
January 3, 2025 15:23
21f5891
to
a13f5e7
Compare
gardener-robot-ci-3
added
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
and removed
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
labels
Jan 3, 2025
…cluster; add webhook to patch sniconfig of virtual kube-apiserver deployment; create controlplane-cert on seed fix
MartinWeindel
force-pushed
the
enh/deploy-runtime
branch
from
January 3, 2025 15:38
a13f5e7
to
81d7278
Compare
gardener-robot-ci-1
added
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
and removed
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
labels
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/control-plane
Control plane related
kind/api-change
API change with impact on API users
kind/enhancement
Enhancement, improvement, extension
needs/ok-to-test
Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
needs/second-opinion
Needs second review by someone else
size/xl
Size of pull request is huge (see gardener-robot robot/bots/size.py)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area control-plane
/kind enhancement
What this PR does / why we need it:
With the introduction of operation extensions, it is possible to deploy an extension on the Garden runtime cluster.
Adjustments both to the deployment of the shoot-cert-service itself and the deployment of the cert-management are needed to deal with the different environment on the Garden runtime cluster. In contrast to the deployment in the shoot namespace on the seed, deploy host and target are the same here. Moreover, some features like
shootIssuers
,dnsChallengeOnShoot
,alerting
are not relevant in this context. Prometheus scraping and Plutono dashboards are also not supported.Addtionally, the default issuer can now be a
CA
issuer instead aACME
issuer to support test and private cloud scenarios.The management of "controlplane-cert" TLS secrets for the runtime cluster and the seeds can be enabled optionally.
On the runtime cluster, this includes fetching the domain names from the
Garden
resources, creating theCertificate
resource, requesting the certificate via its owncert-controller-manager
and patching thevirtual-garden-kube-apiserver
deployment.On the seed clusters, there is also an own
cert-controller-manager
. ACertificate
is created for the wildcard subdomain*.
of the seed ingress domain.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Part of gardener/gardener#9635
Release note: