Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allows skipping fabricmanager download and installation #27

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

engel75
Copy link

@engel75 engel75 commented Jul 25, 2024

What this PR does / why we need it:

For some driver versions no Fabric Manager does exist, eg. 550.90.07 and for smaller GPUs the fabric manager is not needed at all. So we need the possibility to skip the fabricmanager download and installation.

This is what this PR does. It skips the download if the file does not exist, and it also skips the installation if the archive does not exist.

Which issue(s) this PR fixes:
Fixes #26

Special notes for your reviewer:

Release note:

allow skipping download and installation of the fabricmanager if no compatibe version exists.

Copy link
Contributor

@dhague dhague left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR - I agree that the fabricmanager download should be optional, but I would prefer that this is made explicit rather than merely skipping if it doesn't exist for that version. We often do need the fabric manager, and I would want the build to fail if there is none for that driver version.

Could you please amend the PR so that it uses a build argument instead, e.g. --build-arg FABRIC_MANAGER=false, to explicitly skip the download & installation of the fabric manager.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Please allow skipping fabricmanager
2 participants