Adding in model + new dockerfile #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trgardos
requested changes
Jun 26, 2024
|
These should be gone/added into the .gitignore, was able to clone the repo into another directory, remove the files, and then commit. |
|
We need to remove the model from the PR and download and cache it at runtime. See https://github.com/DL4DS/dl4ds_tutor/blob/4d604155dddb130ab01a6234f2ba8b9e978e3e25/code/modules/vectorstore/vectorstore.py#L56 for a function that downloads from HF (but doesn't cache yet). @iranjan31 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added in tinyllama model/lfs storage, updated dockerfile to prevent runtime errors