Set DOCKERBINARY in sysconfig to docker_command #708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow compatibility with the centos packages, where: /usr/bin/docker: a script sourcing /etc/sysconfig/docker and docker-client and docker-client-latest packages install /usr/bin/docker-current and /usr/bin/docker-latest, respectively. Setting DOCKERBINARY in sysconfig defines which of the pkgs should be used.
|
An alternative for us is to set this directly in sysconfig/docker, without using the module. Is this PR something you would be interested in taking, or should we do the alternative instead? |
|
Any feedback on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow compatibility with the centos packages, where:
/usr/bin/docker: a script sourcing /etc/sysconfig/docker
and docker-client and docker-client-latest packages install
/usr/bin/docker-current and /usr/bin/docker-latest, respectively.
Setting DOCKERBINARY in sysconfig defines which of the pkgs should be
used.