Skip to content

Commit

Permalink
testsuite: fix occasional test failure
Browse files Browse the repository at this point in the history
Problem: a test expects to be terminated but sometimes it just
fails with a non-zero exit code.

Use test_must_fail_or_be_terminated.
  • Loading branch information
garlick committed Sep 20, 2024
1 parent c05fea6 commit 5bb62f8
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions t/t0019-tbon-config.t
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,8 @@ test_expect_success 'TOML tbon.interface-hint=wrong type fails' '
test_must_fail flux start -o,--config-path=badhint.toml ${ARGS} true
'
test_expect_success 'tbon.interface-hint=badiface fails' '
test_expect_code 137 flux start -o,-Stbon.interface-hint=badiface \
test_must_fail_or_be_terminated flux start \
-o,-Stbon.interface-hint=badiface \
${ARGS} -s2 -o,-Stbon.prefertcp=1 true
'
test_expect_success 'tbon.interface-hint=default-route works' '
Expand All @@ -89,7 +90,7 @@ test_expect_success 'tcp.interface-hint setting is child default' '
grep hostname childhint.out
'
test_expect_success 'tbon.endpoint cannot be set' '
test_expect_code 137 flux start ${ARGS} -s2 \
test_must_fail_or_be_terminated flux start ${ARGS} -s2 \
-o,--setattr=tbon.endpoint=ipc:///tmp/customflux /bin/true
'
test_expect_success 'tbon.parent-endpoint cannot be read on rank 0' '
Expand Down

0 comments on commit 5bb62f8

Please sign in to comment.