Skip to content

fix(stickup): fixes crashes in Suspense environment #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

chin2km
Copy link
Collaborator

@chin2km chin2km commented Aug 19, 2024

This PR:

  • Does not change any existing functionality or adds new features, but simply makes the library usable in a Suspense environment.

This PR:
- Does not change any existing functionality or adds new features, but simply makes the library usable in a Suspense environment.
@garthenweb
Copy link
Owner

This PR adds a bit of complexity to the stickup library as it makes many things optional.
Technically the contract was that the react-viewport-utils should not call layout functions if no element is defined. Can we move this logic completely to react-viewport-utils?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants