Skip to content
This repository has been archived by the owner on Oct 3, 2024. It is now read-only.

Commit

Permalink
fix: Created by on application-created adds the ip as created by (Unl…
Browse files Browse the repository at this point in the history
…eash#7231)

To avoid leaking potential PII information in the event log, this replaces the IP for the system user as the "created by" field
  • Loading branch information
gastonfournier authored Jun 2, 2024
1 parent 89e5760 commit 54c6ac8
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/lib/features/metrics/instance/instance-service.ts
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ export default class ClientInstanceService {
): Promise<void> {
const value = await clientRegisterSchema.validateAsync(data);
value.clientIp = clientIp;
value.createdBy = clientIp;
value.createdBy = SYSTEM_USER.username!;
this.seenClients[this.clientKey(value)] = value;
this.eventStore.emit(CLIENT_REGISTER, value);
}
Expand Down

0 comments on commit 54c6ac8

Please sign in to comment.