Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ConfigMap for Persistent Plugin File Values #12

Merged
merged 25 commits into from
Apr 18, 2024
Merged

Conversation

hamedsalim1999
Copy link
Member

Description

This pull request introduces a ConfigMap to manage plugin file configurations effectively and refactors the directory structure within the repository for improved organization and maintainability.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link
Member

@mostafa mostafa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! 🙏

LGTM! 🚀

Please consider addressing the comments.

README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
values.yaml Outdated Show resolved Hide resolved
values.yaml Outdated Show resolved Hide resolved
@mostafa
Copy link
Member

mostafa commented Mar 2, 2024

Hey @hamedsalim1999,

Any updates here?

@mostafa mostafa linked an issue Mar 2, 2024 that may be closed by this pull request
.github/workflows/helm-test.yml Outdated Show resolved Hide resolved
.github/workflows/helm-test.yml Outdated Show resolved Hide resolved
.github/workflows/helm-test.yml Outdated Show resolved Hide resolved
.github/workflows/helm-test.yml Outdated Show resolved Hide resolved
values.yaml Outdated Show resolved Hide resolved
Copy link
Member

@mostafa mostafa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hamedsalim1999

Thanks for your contribution! 🙌 LGTM! 🎉

@mostafa mostafa merged commit d9020bf into main Apr 18, 2024
1 check passed
@mostafa mostafa deleted the 8-add-configmap branch April 18, 2024 08:47
@mostafa mostafa linked an issue Apr 18, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support handling configuration files in volumes or as configmaps Add tests
2 participants