Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade dependencies, remove local plugin #148

Merged
merged 1 commit into from
Oct 5, 2018

Conversation

jlengstorf
Copy link
Contributor

closes #107

- Moves all dependencies to the latest stable release
- Switches over to @nikhilag’s Shopify plugin (see angeloashmore/gatsby-source-shopify#10 for reasoning)

closes #107
Copy link

@amberleyromo amberleyromo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Looks cleaner


.gatsby-image-wrapper {
width: 100%;
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pieh @DSchau @KyleAMathews This started happening recently: if I don't apply width: 100% to the wrapper, the image collapses to zero-width/height. Not sure if that's intentional, but wanted to flag it.

@jlengstorf jlengstorf merged commit df6969a into master Oct 5, 2018
@jlengstorf jlengstorf deleted the feat/upgrade-deps branch October 5, 2018 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't require building gatsby-source-shopify-storefront
2 participants