Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename match.Index #408

Closed
wants to merge 1 commit into from
Closed

Rename match.Index #408

wants to merge 1 commit into from

Conversation

rafiramadhana
Copy link
Contributor

Issue: #252

Rename match.Index to match.Value.

@rafiramadhana
Rename match.Index
9bd427c 
Rename match.Index to match.Value.
@coveralls
Copy link
Collaborator

Coverage Status

Coverage: 95.638%. Remained the same when pulling 9bd427c on neverbeenthisweeb:252-rename-index into faca06c on gavv:master.

@gavv
Copy link
Owner

gavv commented Apr 25, 2023

@neverbeenthisweeb Hi! Thanks for PR, but see this comment: #320 (comment)

BTW, I have another go project looking for help: https://github.com/roc-streaming/roc-go. Just in case you're interested :)

@rafiramadhana
Copy link
Contributor Author

@gavv I see, no problem. I am closing this PR. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rafiramadhana @coveralls @gavv