Disable tests that are known to fail on Windows #387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Windows doesn't support colon or at-symbol in paths. This disables the tests on gz-fuel-tools8, as we want to preserve the behavior (to not invalidate anyone's current cache). On gz-fuel-tools9 forward, the fix is implemented. Do not forward port these changes Signed-off-by: Michael Carroll <[email protected]>
azeey
approved these changes
Nov 6, 2023
|
Looks like there's a test failure, but I'm not sure why it hasn't failed on the stable CI build (https://build.osrfoundation.org/job/gz_fuel_tools-ci-gz-fuel-tools8-focal-amd64/2/) |
|
@osrf-jenkins retest this please |
This was referenced Nov 14, 2023
|
@osrf-jenkins retest this please |
Signed-off-by: Michael Carroll <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## gz-fuel-tools8 #387 +/- ##
===============================================
Coverage 75.32% 75.32%
===============================================
Files 20 20
Lines 2910 2910
===============================================
Hits 2192 2192
Misses 718 718 ☔ View full report in Codecov by Sentry. |
|
@osrf-jenkins retest this please |
1 similar comment
|
@osrf-jenkins retest this please |
|
Okay, we only have the old CI names left here, so this is good to go. |
|
Is there a fix for |
|
It probably just needs a forward port, I can do that today. |
Crola1702
pushed a commit
that referenced
this pull request
Jan 3, 2024
Windows doesn't support colon or at-symbol in paths. This disables the tests on gz-fuel-tools8, as we want to preserve the behavior (to not invalidate anyone's current cache). On gz-fuel-tools9 forward, the fix is implemented. Do not forward port these changes Signed-off-by: Michael Carroll <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Windows doesn't support colon or at-symbol in paths. This disables the tests on gz-fuel-tools8, as we want to preserve the behavior (to not invalidate anyone's current cache). On gz-fuel-tools9 forward, the fix is implemented.
Do not forward port these changes.
"Fixes" gz-fuel-tools8 for this issue: #373
gz-fuel-tools9+ fix is here: #376