Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Private function to world identifier #414

Merged
merged 3 commits into from
Apr 16, 2024

Conversation

nkoenig
Copy link
Contributor

@nkoenig nkoenig commented Apr 10, 2024

🎉 New feature

Summary

Adds Private functions to WorldIdentifier. This will help facilitate world upload, which is coming in a follow up PR.

Test it

Run the WorldIdentifier_TEST unit tet.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@github-actions github-actions bot added the 🌱 garden Ignition Garden label Apr 10, 2024
include/gz/fuel_tools/WorldIdentifier.hh Outdated Show resolved Hide resolved
Co-authored-by: Alejandro Hernández Cordero <[email protected]>
Signed-off-by: Nate Koenig <[email protected]>
@nkoenig nkoenig requested a review from ahcorde April 11, 2024 13:07
Copy link
Contributor

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  /github/workspace/include/gz/fuel_tools/WorldIdentifier.hh:159:  Lines should be <= 80 characters long  [whitespace/line_length] [2]

Signed-off-by: Nate Koenig <[email protected]>
@nkoenig nkoenig requested a review from ahcorde April 12, 2024 15:43
@nkoenig nkoenig merged commit 6880aec into gz-fuel-tools8 Apr 16, 2024
4 of 9 checks passed
@nkoenig nkoenig deleted the nkoenig/worldid_private branch April 16, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants