Update RenderingIface_TEST's RegisterEngine test to only load the specified engine #1098
+20
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ian Chen <[email protected]>
ahcorde
approved these changes
Jan 10, 2025
iche033
added a commit
that referenced
this pull request
Jan 14, 2025
Signed-off-by: Ian Chen <[email protected]>
|
@Mergifyio backport gz-rendering8 |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Jan 14, 2025
Signed-off-by: Ian Chen <[email protected]> (cherry picked from commit 52ac1de)
8 tasks
iche033
added a commit
that referenced
this pull request
Jan 14, 2025
Signed-off-by: Ian Chen <[email protected]> (cherry picked from commit 52ac1de)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Fixes #1072
Summary
The
RenderingIface_TESTtried to load theogre(ogre 1.x) plugin even whenGZ_ENGINE_TO_TESTset toogre2. This PR updates the test to ensure that the specified engine is used in the test. While doing this I found and fixed a bug when unregistering a default engine by name (e.g.ogre2).Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.