-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed Odometry Publisher Angular Velocity Singularity in 3D #2348
base: gz-sim8
Are you sure you want to change the base?
Conversation
Signed-off-by: Tom Creutz <[email protected]>
Signed-off-by: Tom Creutz <[email protected]>
Signed-off-by: Tom Creutz <[email protected]>
Signed-off-by: Tom Creutz <[email protected]>
Signed-off-by: Tom Creutz <[email protected]>
Can you roll back the style changes please? We need to just update the logic without altering the style of the entire file. |
Signed-off-by: Tom Creutz <[email protected]>
Previously the angular velocity was represented in the world coordinate frame. This change will rotate it to be represented in the body coordinate frame Signed-off-by: Tom Creutz <[email protected]>
Hi @mjcarroll, |
Hello @mjcarroll, |
馃 Bug fix
Fixes #2347
Summary
The angular velocity was calculated using euler angles which led to singularities (see #2347 for a more detailed description). In addition to the fix, I also removed the usage of the rolling mean accumulator for angular velocity. While I see its usefulness for outlier rejections, I still didn't really see why this would be necessary. If the maintainers want to keep this mean accumulator, I'll be happy to reimplement it. Also the commit changes seem a bit messy, I was using clang format with the Google C++ Style guide as configuration, which leaded to the changed formatting that you can see in the pull request.
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.