Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Populate joint forces through physics #952

Conversation

vatanaksoytezer
Copy link

@vatanaksoytezer vatanaksoytezer commented Jul 31, 2021

🎉 New feature

Closes #883

Summary

Exports joint forces through physics.cc to enable force-torque sensors and efforts through joint state publisher.

Test it

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

Signed-off-by: Vatan Aksoy Tezer <[email protected]>
@osrf-triage osrf-triage added this to Inbox in Core development Jul 31, 2021
@github-actions github-actions bot added the 🏢 edifice Ignition Edifice label Jul 31, 2021
@chapulina chapulina added the needs upstream release Blocked by a release of an upstream library label Aug 2, 2021
@chapulina chapulina moved this from Inbox to In review in Core development Aug 2, 2021
Signed-off-by: Vatan Aksoy Tezer <[email protected]>
@azeey
Copy link
Contributor

azeey commented Aug 2, 2021

Just wanted to say that I'm not sure if we have consensus on whether gazebosim/gz-physics#143 (computing inverse dynamics) is how we'll obtain joint forces, so it might take some time before we can merge this PR.

@vatanaksoytezer
Copy link
Author

vatanaksoytezer commented Aug 3, 2021

Just wanted to say that I'm not sure if we have consensus on whether ignitionrobotics/ign-physics#143 (computing inverse dynamics) is how we'll obtain joint forces, so it might take some time before we can merge this PR.

@azeey I think regardless of gazebosim/gz-physics#143 getting merged, this PR would still be necessary in any implementation for calculating joint forces.

Regardless, gazebosim/gz-physics#143 seemed pretty fast to me in calculating inverse dynamics for 25 joints in a very complex scenario. I was around 95-99% real time all the time with a moderate gaming PC (i7 9750H + 1660Ti) in that simulation. Let me know if there are any tests you would like me to do to compare performances or help choose the right implementation.

I strongly think joint forces would be pretty helpful for other people using the simulation, whether to debug or use them in their calculations. So, I would love help get these merged and ready do some tests / more PRs towards it.

@vatanaksoytezer
Copy link
Author

vatanaksoytezer commented Oct 7, 2021

Closing since I believe this won't be merged in favor of other implementation that is merged in Fortress. Though as of my testing I can't read efforts / forces through joint states in fortress binaries.

@chapulina
Copy link
Contributor

Though as of my testing I can't read efforts / forces through joint states in fortress binaries.

We should make sure that this works. Maybe capture it in an issue that we look into soon?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏢 edifice Ignition Edifice needs upstream release Blocked by a release of an upstream library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JointStatePublisher does not publish efforts
3 participants