Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove shebang from shell completion files #132

Merged

Conversation

cottsay
Copy link
Contributor

@cottsay cottsay commented Jan 25, 2024

🦟 Bug fix

Summary

These files are not executable while checked into the repository or after installation on the system. Additionally, executing them will do nothing because they must be "sourced" to export their functionality into the shell.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@cottsay cottsay requested a review from caguero as a code owner January 25, 2024 17:01
These files are not executable while checked into the repository or
after installation on the system. Additionally, executing them will do
nothing because they must be "sourced" to export their functionality
into the shell.

Signed-off-by: Scott K Logan <[email protected]>
@cottsay cottsay force-pushed the remove-shebang-shell-completion branch from 23ae9ce to 3f82851 Compare January 25, 2024 17:01
@github-actions github-actions bot added 🌱 garden Ignition Garden 🎵 harmonic Gazebo Harmonic 🏛️ ionic Gazebo Ionic labels Jan 25, 2024
@mjcarroll mjcarroll merged commit fd1e484 into gazebosim:gz-tools2 Jan 29, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden 🎵 harmonic Gazebo Harmonic 🏛️ ionic Gazebo Ionic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants